Skip to content

Clean-up some more headers #14416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2024
Merged

Clean-up some more headers #14416

merged 1 commit into from
Jun 8, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jun 1, 2024 •
edited
Loading

Remove unused headers (such as php_ini.h for extensions that don't define INI settings)
Use more specific headers when possible

@Girgias
Clean-up some more headers
320fc6b 
Remove unused headers (such as php_ini.h for extensions that don't define INI settings)
Use more specific headers when possible
@Girgias Girgias force-pushed the ext-header-cleanup2 branch from 818f7ac to 320fc6b Compare June 1, 2024 18:24
@Girgias Girgias marked this pull request as ready for review June 1, 2024 18:58
NattyNarwhal
NattyNarwhal approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok odbc

devnexen
devnexen approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pcntl/pgsql lctm

nielsdos
nielsdos approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for xml, xmlwriter, xsl, soap, simplexml

alexdowad
alexdowad approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@alexdowad alexdowad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection for mbstring.

@Girgias Girgias merged commit fd2d869 into php:master Jun 8, 2024
10 of 11 checks passed
@Girgias Girgias deleted the ext-header-cleanup2 branch June 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdowad alexdowad alexdowad approved these changes

@NattyNarwhal NattyNarwhal NattyNarwhal approved these changes

@devnexen devnexen devnexen approved these changes

@nielsdos nielsdos nielsdos approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees
No one assigned
Labels
Extension: ctype Extension: date Extension: exif Extension: filter Extension: gmp Extension: iconv Extension: intl Extension: json Extension: mbstring Extension: mysqli Extension: odbc Extension: openssl Extension: pcntl Extension: pgsql Extension: readline Extension: session Extension: shmop Extension: simplexml Extension: soap Extension: sodium Extension: spl Extension: sqlite3 Extension: sysvmsg Extension: sysvshm Extension: tokenizer Extension: xml Extension: xmlwriter Extension: xsl Extension: zip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Girgias @alexdowad @NattyNarwhal @devnexen @nielsdos